[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen added a comment. Wild guess is that `2> %t.err` should be removed from the `-verify` lines? That change passes in the single env I have access to. @rnk any idea what might be going on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

ormris added a comment. Hi Zach, The tests in this patch are failing on this PS4 windows bot. Could you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/30273/steps/test-check-all/logs/stdio Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f9cf42facaf: Allow /D flags absent during PCH creation under msvc-compat (authored by zahen, committed by rnk). Changed prior to commit: https://reviews.llvm.org/D72405?vs=238147=238149#toc

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D72405#1818237 , @zahen wrote: > I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` > because the errors were reported against

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk updated this revision to Diff 238147. rnk added a comment. - use %clang_cc1 as possible in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72405/new/ https://reviews.llvm.org/D72405 Files: clang/lib/Lex/PPDirectives.cpp

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen updated this revision to Diff 237795. zahen added a comment. Incorporate review feedback. I had no luck converting the CHECK-FOO & CHECK-NOFOO tests to use `-verify` because the errors were reported against "(frontend)" error: 'error' diagnostics seen but not expected: (frontend):

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

rnk added subscribers: aganea, mikerice. rnk added a comment. Honestly, MSVC's behavior makes more sense to me. Usually warnings tell the user they are doing something silly, and then let them do it anyway. Without this change, there is no way to add extra macros to some compilations, even if

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen added a comment. My change keeps the diagnostic so consumers can opt into the same enforcement that exists today. Furthermore, the existing fuzzy-pch.c tests show that new -D flags are allowed under a "clangier" PCH structure. None of the existing tests error on: BAR bar = 17; when

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

thakis added a comment. Why do you want this? Isn't it always easy to fix your build instead? In general, stricter is better when we can get away with it, and since we've had this behavior for a while… Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72405: Allow /D flags absent during PCH creation under msvc-compat

zahen created this revision. zahen added reviewers: rnk, thakis, hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch adding a new /D flag when compiling a source file that consumed a PCH with clang-cl would issue a diagnostic and then fail. With the