[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

This revision was automatically updated to reflect the committed changes. Closed by commit rGc348a2674b57: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix (authored by sylvestre.ledru). Changed prior to commit: https://reviews.llvm.org/D72421?vs=236924&id=237178#toc

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru marked 5 inline comments as done. sylvestre.ledru added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:372 +f.write(' :header: "Name", "Offers fixes"\n') +f.write(' :widths: 50, 20\n\n') f.writelines(checks)

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks for updating the script! A few nits, otherwise LG, if this works. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:308 + +checkerCode = os.path.

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

njames93 added a comment. In D72421#1811544 , @sylvestre.ledru wrote: > > Thanks for this, Also how would you feel about adding a parameter to the > > script that could create alias definitions in much the same way? > > Do you have more details about you

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. > Thanks for this, Also how would you feel about adding a parameter to the > script that could create alias definitions in much the same way? Do you have more details about your expectation? I could have a look but in a separate commit :) Repository: rG LLVM

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. It finds some stuff that I missed in the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 ___ cfe-commits mailing list c

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

njames93 added a comment. Thanks for this, Also how would you feel about adding a parameter to the script that could create alias definitions in much the same way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D