efriedma marked an inline comment as done.
efriedma added inline comments.
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413
unsigned MaxRecurse) {
- if (isa(Mask))
+ if (all_of(Mask, [](int Elem) { return Elem == -1; }))
simoll added inline comments.
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413
unsigned MaxRecurse) {
- if (isa(Mask))
+ if (all_of(Mask, [](int Elem) { return Elem == -1; }))
return UndefValue::get(RetTy);
efriedma updated this revision to Diff 237463.
efriedma added a comment.
Figured out the changes necessary to get bitcode reading/writing working.
ninja check now passes.
Not sure what parts I should split off to get reviewed separately. Probably
the GlobalISel changes could be split off
efriedma marked an inline comment as done.
efriedma added inline comments.
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413
unsigned MaxRecurse) {
- if (isa(Mask))
+ if (all_of(Mask, [](int Elem) { return Elem == -1; }))
xbolva00 added inline comments.
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4413
unsigned MaxRecurse) {
- if (isa(Mask))
+ if (all_of(Mask, [](int Elem) { return Elem == -1; }))
return UndefValue::get(RetTy);
efriedma updated this revision to Diff 237453.
efriedma added a comment.
Herald added subscribers: cfe-commits, Petar.Avramovic, dexonsmith, nhaehnle,
jvesely, arsenm.
Herald added a project: clang.
Add more comments, fixed the GlobalISel representation of shuffles, misc other
cleanups. Still
