[PATCH] D72500: [clangd] Show hover info for expressions

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/5837/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 ___ cfe-commits

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:519 + // + // expression : `int` // Note that we are making use of a level-3 heading because VSCode renders sammccall wrote: > nit: this is just "expression" not yet, it will be

[PATCH] D72500: [clangd] Show hover info for expressions

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG4d14bfaa2cb1: [clangd] Show hower info for expressions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72500: [clangd] Show hover info for expressions

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG! Comment at: clang-tools-extra/clangd/Hover.cpp:519 + // + // expression : `int` // Note that we are making use of a level-3 heading because VSCode renders

[PATCH] D72500: [clangd] Show hover info for expressions

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61794 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet updated this revision to Diff 238009. kadircet marked 3 inline comments as done. kadircet added a comment. - Populate `Name` for expressions - Don't special case `StringLiteral`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/

[PATCH] D72500: [clangd] Show hover info for expressions

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:431 + +// Generates hover info for string literals and evaluatable expressions. +// FIXME: Support hover for user-defined literals. I'd really like to avoid *any literals here in

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72500: [clangd] Show hover info for expressions

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72500: [clangd] Show hover info for expressions

kadircet updated this revision to Diff 237660. kadircet added a comment. - Update presentation for expressions, which doesn't have `Name` field set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 Files:

[PATCH] D72500: [clangd] Show hover info for expressions

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :