[PATCH] D72500: [clangd] Show hower info for expressions

kadircet updated this revision to Diff 237649. kadircet added a comment. - Ignore literals Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72500/new/ https://reviews.llvm.org/D72500 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D72500: [clangd] Show hower info for expressions

kadircet added a comment. In D72500#1813975 , @sammccall wrote: > Basing this on the hover for the type doesn't seem right. e.g. `int` should > be the `Type` rather than the `Name`. > > Rather than printing the value if evaluable, I think we should only

[PATCH] D72500: [clangd] Show hower info for expressions

lh123 added a comment. In D72500#1813975 , @sammccall wrote: > I think we should avoid triggering for literals. Maybe some exceptions, but a > hover saying that 0 is an int with value 0 seems silly. Yes, hovering over `IntegerLiteral/FloatingLiteral`

[PATCH] D72500: [clangd] Show hower info for expressions

sammccall added a comment. Basing this on the hover for the type doesn't seem right. e.g. `int` should be the `Type` rather than the `Name`. Rather than printing the value if evaluable, I think we should only show the hover if evaluable. There's a cost to showing it and the value of just the

[PATCH] D72500: [clangd] Show hower info for expressions

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D72500: [clangd] Show hower info for expressions

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This currently populates only the Name with the expression's type and Value if expression is