[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-05-17 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D72530#2040521 , @steveire wrote: > In D72530#2038561 , @aaron.ballman > wrote: > > > The

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-05-17 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In D72530#2038561 , @aaron.ballman wrote: > The changes here look reasonable, but can some of this code be simplified to > use the default behavior and less complex matchers that don't have to > carefully ignore implicit

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-05-15 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. The changes here look reasonable, but can some of this code be simplified to use the default behavior and less complex matchers that don't have to carefully ignore implicit nodes? This would demonstrate that the feature really is an improvement over the status

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-01-28 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 240816. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-01-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 237417. steveire added a comment. Fix case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72530/new/ https://reviews.llvm.org/D72530 Files: clang-tools-extra/clang-tidy/abseil/DurationDivisionCheck.cpp

[PATCH] D72530: Set traversal explicitly where needed in clang-tidy

2020-01-10 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72530 Files: