[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. In D72553#1815497 , @njames93 wrote: > could this do with an alias into performance? If it was 1997, I'd say yes, but I am not

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 299443. njames93 added a comment. Rebased and fix issues relating to rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. Sorry for missing this review, i simply hadn't time :/ All my concerns are addressed and I think this is LGTM after rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added a comment. Running this over llvm with only clang and clang-tools-extra enabled this was the output. ninja check-all ran successfully with no errors. Didn't try transform `TransformCxxOpCalls` or

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 244557. njames93 added a comment. - Fix order in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 244555. njames93 added a comment. - Added option to enable transforming template dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62198 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 240584. njames93 marked an inline comment as done. njames93 added a comment. - Added test case when the inc and dec operators are found in a base class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance-prefer-pre-increment-disable-cpp-opcalls.cpp:44 +}; + +void foo() { njames93 wrote: > JonasToth wrote: > > Test-cases that I would like to see: > > > > - only

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62197 tests passed, 1 failed and 815 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_timedmutex_requirements/thread_timedmutex_class/lock.pass.cpp {icon times-circle

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 240402. njames93 marked 5 inline comments as done. njames93 added a comment. - Address some nits, more test cases need adding though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/PreferPreIncrementCheck.cpp:63 + + if (!getLangOpts().CPlusPlus || !TransformCxxOpCalls) +return; JonasToth wrote: > Why would you deactivate the check for c-code? > I

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

JonasToth added a comment. Yeah, the libc++ failures are not your fault :) My 2 cents added. Comment at: clang-tools-extra/clang-tidy/performance/PreferPreIncrementCheck.cpp:63 + + if (!getLangOpts().CPlusPlus || !TransformCxxOpCalls) +return; Why would

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 added a comment. Gonna throw it out there, those pre merge fails aren't anything to do with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62129 tests passed, 5 failed and 807 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 239988. njames93 added a comment. - Rebase trunk and fix a few nits with test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61939 tests passed, 5 failed and 782 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61943 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 238740. njames93 added a comment. - Streamlined replacement application Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files:

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

lebedev.ri added a comment. In D72553#1820692 , @njames93 wrote: > - moved check from llvm module to performance Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61861 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

njames93 updated this revision to Diff 238104. njames93 added a comment. - moved check from llvm module to performance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: