This revision was automatically updated to reflect the committed changes.
kmclaughlin marked an inline comment as done.
Closed by commit rGfe3bb8ec9683: [AArch64][SVE] Add ImmArg property to
intrinsics with immediates (authored by kmclaughlin).
Repository:
rG LLVM Github Monorepo
CHANGES
kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1108
+ def "" : AsmVectorIndexOpnd, PatLeaf<(ty imm), pred>;
+ def _timm : AsmVectorIndexOpnd, PatLeaf<(ty timm), pred>;
+}
kmclaughlin updated this revision to Diff 238445.
kmclaughlin added a comment.
- Replace PatLeaf with ImmLeaf & TImmLeaf in the VectorIndex multiclass
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72612/new/
https://reviews.llvm.org/D72612
Files:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with one question
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1108
+ def "" : AsmVectorIndexOpnd, PatLeaf<(ty imm), pred>;
+ def _timm :
kmclaughlin updated this revision to Diff 238199.
kmclaughlin added a comment.
- Removed shiftimm patterns and reused tvecshiftR8, etc
- Removed complex patterns used by AsmVectorIndexOpnd and instead created a
multiclass (VectorIndex) to create a PatLeaf with timm if "_timm" is appended
efriedma added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1099
+class AsmVectorIndexOpnd
+: Operand, ComplexPattern", []>
{
let ParserMatchClass = mc;
sdesmalen wrote:
> @efriedma @rengolin The idea here is to use a
sdesmalen added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1099
+class AsmVectorIndexOpnd
+: Operand, ComplexPattern", []>
{
let ParserMatchClass = mc;
@efriedma @rengolin The idea here is to use a ComplexPattern to
kmclaughlin created this revision.
kmclaughlin added reviewers: efriedma, sdesmalen, andwar.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Several SVE intrinsics with immediate arguments (including
