[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61885 tests passed, 0 failed and 782 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72622: [clangd] Add a ruler after header in hover

This revision was automatically updated to reflect the committed changes. Closed by commit rGd74a3d470c31: [clangd] Add a ruler after header in hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 238243. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.llvm.org/D72622 Files:

[PATCH] D72622: [clangd] Add a ruler after header in hover

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.cpp:121 std::string renderBlocks(llvm::ArrayRef> Children, - void (Block::*RenderFunc)(llvm::raw_ostream &) const) { + const RenderType RT) {

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61819 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237934. kadircet added a comment. - Per offline discussions, do post processing to get rid of multiple ruler occurences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61802 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61802 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:553 + // Put a linebreak after header to increase readability. + Output.addRuler(); sammccall wrote: > (When merging with D72623, I'm assuming return type will go below this

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237886. kadircet marked 5 inline comments as done. kadircet added a comment. - Increase control around paddings for plaintext rendering. - Add another ruler before definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet updated this revision to Diff 237887. kadircet added a comment. - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72622/new/ https://reviews.llvm.org/D72622 Files: clang-tools-extra/clangd/FormattedString.cpp

[PATCH] D72622: [clangd] Add a ruler after header in hover

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:553 + // Put a linebreak after header to increase readability. + Output.addRuler(); (When

[PATCH] D72622: [clangd] Add a ruler after header in hover

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts :

[PATCH] D72622: [clangd] Add a ruler after header in hover

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72622 Files: