[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

hans added a comment. Ah, you're right, it's there. The reason for my comment was http://lists.llvm.org/pipermail/llvm-branch-commits/2020-January/013555.html but it seems it was also successfully pushed to master. Sorry for the noise. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

malcolm.parsons added a comment. In D72630#1823525 , @hans wrote: > It seems that while this commit got pushed to GitHub, it's not actually part > of master or any other branches. This was my first push to llvm's GitHub repository, so I may have done

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

hans added a comment. It seems that while this commit got pushed to GitHub, it's not actually part of master or any other branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72630/new/ https://reviews.llvm.org/D72630

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

This revision was automatically updated to reflect the committed changes. malcolm.parsons marked an inline comment as done. Closed by commit rG45924eb46716: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init (authored by malcolm.parsons). Repository: rG LLVM Github

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

JonasToth added a comment. K. Thank you for fixing it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72630/new/ https://reviews.llvm.org/D72630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

malcolm.parsons marked 2 inline comments as done. malcolm.parsons added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-default-member-init.cpp:294 int e3 = {5}; - int e4 = 5; + int e4{5}; int e5 = -5; JonasToth

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM in general. The linked bug report misses a "4" --> PR0, so please the description for that. Comment at:

[PATCH] D72630: [clang-tidy] Ignore implicit casts in modernize-use-default-member-init

malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, alexfh, JonasToth. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Initialising a pointer from nullptr involves an implicit cast. Ignore it after getting initialiser from