[PATCH] D72644: [clang] Add -fignore-exceptions

2020-02-12 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D72644#1871662 , @lebedev.ri wrote: > This review omitted cfe-commits list Good catch, I didn't notice that in the review. I think we can address any concerns with post-commit feedback. Repository: rG LLVM Github Mo

[PATCH] D72644: [clang] Add -fignore-exceptions

2020-02-12 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added a comment. In D72644#1871662 , @lebedev.ri wrote: > This review omitted cfe-commits list Didn't realized that. Since this is approved and committed, I guess I will keep monitor messages in this review, and address any post-commit comments

[PATCH] D72644: [clang] Add -fignore-exceptions

2020-02-12 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added a comment. In D72644#1868812 , @aaron.ballman wrote: > Sorry about the delayed review. I think this patch basically LG, thank you! Thanks Aaron. Addressed your comments in the commits. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D72644: [clang] Add -fignore-exceptions

2020-02-12 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. This review omitted cfe-commits list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72644/new/ https://reviews.llvm.org/D72644 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D72644: [clang] Add -fignore-exceptions

2020-02-12 Thread Jason Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG55e2678fcd4d: [clang] Add -fignore-exceptions (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D72644?vs=2