[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow added a comment. > One commit for the clang changes should be ok; it's a very small diff. But > I'm still not sure if the driver change induces frontend diffs that we should > make visible via tests. The only thing I can think of is that it changes whether/when `__FAST_MATH__` is

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1824659 , @wristow wrote: > This all sounds good to me. > > So to make sure we're all on the same page, my understanding is that the plan > forward is: > > 1. Make the Clang change first (including adding another pair of

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow added a comment. This all sounds good to me. So to make sure we're all on the same page, my understanding is that the plan forward is: 1. Make the Clang change first (including adding another pair of tests for `-ffp-contract=on`). 2. Update the LLVM tests illustrating the current

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

mcberg2017 added a comment. I should do the other DAG combiner fma changes after this is wrapped up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675 ___ cfe-commits mailing list

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1823227 , @mcberg2017 wrote: > We crossed that bridge internally at Apple a while ago, meaning I have some > code debt for cleaning up open source for fma formation that uses contract > and reassoc differently than we

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

mcberg2017 added a comment. We crossed that bridge internally at Apple a while ago, meaning I have some code debt for cleaning up open source for fma formation that uses contract and reassoc differently than we do today, both together and separately, case by case. CHANGES SINCE LAST ACTION

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow marked an inline comment as done. wristow added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fmf-propagation.ll:201-203 ; fma(X, 7.0, X * 42.0) --> X * 49.0 -; This is the minimum FMF needed for this transform - the FMA allows reassociation. +; This is the

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added inline comments. Comment at: llvm/test/CodeGen/PowerPC/fmf-propagation.ll:201-203 ; fma(X, 7.0, X * 42.0) --> X * 49.0 -; This is the minimum FMF needed for this transform - the FMA allows reassociation. +; This is the minimum FMF needed for this transform - the

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238143. wristow retitled this revision from "ix -ffast-math/-ffp-contract interaction" to "Fix -ffast-math/-ffp-contract interaction". wristow added a comment. Addressed comments from @hfinkel . CHANGES SINCE LAST ACTION