[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

2020-01-14 Thread Warren Ristow via Phabricator via cfe-commits
wristow marked 3 inline comments as done. wristow added a comment. Thanks for the quick feedback @hfinkel Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2721 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath

[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

2020-01-13 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added inline comments. Herald added a subscriber: wuzish. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2721 if (!MathErrno && AssociativeMath && ReciprocalMath && !SignedZeros && - !TrappingMath) + !TrappingMath && !FPContractDisabled)

[PATCH] D72675: ix -ffast-math/-ffp-contract interaction

2020-01-13 Thread Warren Ristow via Phabricator via cfe-commits
wristow created this revision. wristow added reviewers: spatel, mcberg2017. Herald added subscribers: jsji, hiraditya, nemanjai. Herald added a project: LLVM. Fused Multiply Add (FMA) was not always being disabled when the switch `-ffp-contract=off` was used. More specifically, FMA is enabled