This revision was automatically updated to reflect the committed changes.
Closed by commit rG87d8ae700b80: [clang][cmake] Include generated rst files in
html built by docs-clang-html… (authored by tstellar).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
delcypher accepted this revision.
delcypher added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for addressing all the issues I raised.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72875/new/
tstellar added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72875/new/
https://reviews.llvm.org/D72875
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
tstellar updated this revision to Diff 247123.
tstellar marked 4 inline comments as done.
tstellar added a comment.
Address most recent review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72875/new/
https://reviews.llvm.org/D72875
delcypher requested changes to this revision.
delcypher added inline comments.
This revision now requires changes to proceed.
Comment at: clang/docs/CMakeLists.txt:93
+function (gen_rst_file output_file td_option source)
+ get_filename_component(TABLEGEN_INCLUDE_DIR
tstellar added a comment.
Any other commits before I commit this?
Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33
+ if (NOT ARG_SOURCE_DIR)
+set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
+ endif()
delcypher wrote:
> @tstellar I'm not 100% sure
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed
and 783 were skipped.
{icon question-circle color=gray} clang-tidy: unknown.
{icon check-circle color=green} clang-format: pass.
Build artifacts
tstellar updated this revision to Diff 238914.
tstellar marked 2 inline comments as done.
tstellar added a comment.
- Add quotes around ${CMAKE_CURRENT_SOURCE_DIR}
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72875/new/
delcypher added inline comments.
Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33
+ if (NOT ARG_SOURCE_DIR)
+set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
+ endif()
@tstellar I'm not 100% sure about this but I think you probably want
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed
and 783 were skipped.
{icon question-circle color=gray} clang-tidy: unknown.
{icon check-circle color=green} clang-format: pass.
Build artifacts
tstellar updated this revision to Diff 238893.
tstellar added a comment.
- Fix indentation.
- Remove placeholder AttributeReference.rst. The install target was replacing
the generated AttributeReference.rst with this which caused the html page to be
empty.
- Tested with stand-alone clang
mgorny accepted this revision.
mgorny added a comment.
This revision is now accepted and ready to land.
Besides the mentioned misindent, the CMake code looks correct. Could you test
whether it works with standalone (out-of-LLVM) builds as well?
Comment at:
aaron.ballman added a comment.
Thank you for working on this, I think this is a great improvement. I am not
super qualified to review the cmake, but it looks eminently reasonable to me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72875/new/
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed
and 783 were skipped.
{icon question-circle color=gray} clang-tidy: unknown.
{icon check-circle color=green} clang-format: pass.
Build artifacts
tstellar created this revision.
tstellar added reviewers: rsmith, aaron.ballman, beanz, smeenai, phosek,
compnerd.
Herald added subscribers: llvm-commits, mgorny.
Herald added projects: clang, LLVM.
This is an attempt to simply the process of building the clang
documentation, which should help
15 matches
Mail list logo
