[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

2020-01-17 Thread ido via Phabricator via cfe-commits
ykfre added a comment. In D72910#1826293 , @dim wrote: > Aha, which version of clang-cl are you using? With the released version of > clang-cl 9.0.1, I get a warning instead of an error: > > cleanup.cpp(15,5): warning: jump from this goto statement to

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

2020-01-17 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. Aha, which version of clang-cl are you using? With the released version of clang-cl 9.0.1, I get a warning instead of an error: cleanup.cpp(15,5): warning: jump from this goto statement to its label is a Microsoft extension [-Wmicrosoft-goto] goto

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

2020-01-17 Thread ido via Phabricator via cfe-commits
ykfre added a comment. In D72910#1826108 , @dim wrote: > Eh, no it does not crash clang, at least not here? Instead it gives you a > compile error, as it should: > > cleanup.cpp:15:5: error: cannot jump from this goto statement to its label >

[PATCH] D72910: Fix a bug with clang with object destructor, while skipping object initialization - make clang crash

2020-01-17 Thread Dimitry Andric via Phabricator via cfe-commits
dim added a comment. Eh, no it does not crash clang, at least not here? Instead it gives you a compile error, as it should: cleanup.cpp:15:5: error: cannot jump from this goto statement to its label goto clean_up; ^ cleanup.cpp:20:7: note: jump bypasses