[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

miscco added a comment. Ah sorry about that, I overlooked that we had special cased tests without count. Thanks Billy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7dcbe90cc2d: [libc++] Fix overly complicated test of std::spans extent (authored by ldionne). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Changed prior to commit:

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. In D73138#1881198 , @BillyONeal wrote: > @ldionne I think you're correct, though the test there is more complex than > it needs to be (because the

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal added a comment. @ldionne I think you're correct, though the test there is more complex than it needs to be (because the ==Count cases are the only ever encountered here). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

ldionne added a comment. I think this was addressed by https://reviews.llvm.org/D71997. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73138/new/ https://reviews.llvm.org/D73138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73138: [libcxx] [test] Correct asserted type in subspan test; subspan with count should never produce dynamic_extent

BillyONeal created this revision. BillyONeal added reviewers: ldionne, EricWF, mclow.lists. Herald added subscribers: dexonsmith, christof. I'm not sure if this was a change in the standard behavior or if it was a typo in libcxx from the beginning. http://eel.is/c++draft/span.sub#10 says that if