NoQ added inline comments.
Comment at: clang/test/Analysis/fuchsia_handle.cpp:80
+ zx_status_t status = zx_channel_create(0, &sa, &sb);
+ // expected-note@-1 {{Handle allocated through 2nd parameter}}
+ if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}}
--
NoQ added inline comments.
Comment at: clang/test/Analysis/fuchsia_handle.cpp:80
+ zx_status_t status = zx_channel_create(0, &sa, &sb);
+ // expected-note@-1 {{Handle allocated through 2nd parameter}}
+ if (status == 0) { // expected-note {{Assuming 'status' is equal to 0}}
--
jroelofs added inline comments.
Comment at: clang/test/Analysis/fuchsia_handle.cpp:80
+ zx_status_t status = zx_channel_create(0, &sa, &sb);
+ // expected-note@-1 {{Handle allocated through 2nd parameter}}
+ if (status == 0) { // expected-note {{Assuming 'status' is equal to 0
jroelofs added subscribers: dcoughlin, jroelofs.
jroelofs added inline comments.
Herald added subscribers: ASDenysPetrov, martong.
Comment at: clang/test/Analysis/fuchsia_handle.cpp:80
+ zx_status_t status = zx_channel_create(0, &sa, &sb);
+ // expected-note@-1 {{Handle allocat
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc98d98ba9b0f: [analyzer] Fix handle leak false positive when
the handle dies too early (authored by xazax.hun).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yay, it actually worked!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73151/new/
https://reviews.llvm.org/D73151
___
cfe-commits mailing list
xazax.hun added a comment.
I've rerun this on Fuchsia and it got the same results as the previous approach
:).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73151/new/
https://reviews.llvm.org/D73151
___
cfe-commits mailing list
cfe-commit
xazax.hun updated this revision to Diff 240337.
xazax.hun added a comment.
- Address review comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73151/new/
https://reviews.llvm.org/D73151
Files:
clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp
clang/test/Analysis/fuchs
xazax.hun marked 4 inline comments as done.
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135
+ static HandleState getWithoutError(HandleState S) {
+return HandleState(S.K, nullptr);
+ }
xazax.hu
xazax.hun marked 2 inline comments as done.
xazax.hun added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135
+ static HandleState getWithoutError(HandleState S) {
+return HandleState(S.K, nullptr);
+ }
NoQ wrot
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:133-135
+ static HandleState getWithoutError(HandleState S) {
+return HandleState(S.K, nullptr);
+ }
It already makes me mildly uncomfortable that our data is
xazax.hun updated this revision to Diff 239469.
xazax.hun added a comment.
- Minor refactoring.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73151/new/
https://reviews.llvm.org/D73151
Files:
clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp
clang/test/Analysis/fuchsia_han
xazax.hun created this revision.
xazax.hun added reviewers: NoQ, haowei.
xazax.hun added a project: clang.
Herald added subscribers: Charusso, gamesh411, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
In case the handle symbol dies too early, even
13 matches
Mail list logo
