[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG3dd5a298bfff: [clang] Annotating C++'s `operator new` with more attributes (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 246575. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 245656. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 242388. lebedev.ri added a comment. Rebased, NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 Files: clang/include/clang/AST/Decl.h clang/include/clang/Sema/

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri added a comment. bump @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73380/new/ https://reviews.llvm.org/D73380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 240530. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. For the sake of forward progress, remove overly optimistic alignment annotation, and replace it with FIXME. I have some ideas how to deal with that, but i'd prefer to deal wit

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri marked 3 inline comments as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { ---

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { lebedev.ri wrote: > rsmith wrote: > > T

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { ---

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14361 +/// attributes are applied to declarations. +void Sema::AddKnownFunctionAttributesForReplaceableGlobalAllocationFunction( +FunctionDecl *FD) { This should all be done by CodeGen, not

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. In D73380#1839603 , @xbolva00 wrote: > LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info > added by clang will not increase power of LLVM. Or? To be hon

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

xbolva00 added a comment. LLVM already infers noalias nonnull for eg. _Znwm so noalias and nonnull info added by clang will not increase power of LLVM. Or? Alignment info is useful I think. Comment at: clang/test/CodeGenCXX/builtin-operator-new-delete.cpp:54 } -// CHECK: dec

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri created this revision. lebedev.ri added reviewers: rsandifo, erichkeane, rjmccall, jdoerfert, eugenis. lebedev.ri added a project: LLVM. Herald added subscribers: atanasyan, jrtc27. Herald added a project: clang. lebedev.ri added a parent revision: D73020: [Sema] Perform call checking wh