This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rG0d893fda4305: [clangd] Add a symbol-name-based blacklist for
rename. (authored by hokein).
Changed prior to commit:
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:225
TargetIDs.insert(SymbolID(USR));
-
std::vector Results;
nit: maybe revert this
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location());
if (DeclsUnderCursor.empty())
kadircet wrote:
> hokein wrote:
> > kadircet wrote:
> > >
hokein updated this revision to Diff 240853.
hokein marked an inline comment as done.
hokein added a comment.
address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73450/new/
https://reviews.llvm.org/D73450
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location());
if (DeclsUnderCursor.empty())
hokein wrote:
> kadircet wrote:
> > hokein wrote:
> > >
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location());
if (DeclsUnderCursor.empty())
kadircet wrote:
>
hokein updated this revision to Diff 240822.
hokein marked an inline comment as done.
hokein added a comment.
move the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73450/new/
https://reviews.llvm.org/D73450
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location());
if (DeclsUnderCursor.empty())
hokein wrote:
> kadircet wrote:
> > `locateDeclAt` is
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon check-circle color=green} clang-format: pass.
Build artifacts
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed
and 815 were skipped.
{icon check-circle color=green} clang-tidy: pass.
{icon times-circle color=red} clang-format: fail. Please format your changes
with clang-format by running
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466
auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location());
if (DeclsUnderCursor.empty())
kadircet wrote:
> `locateDeclAt` is already working on
hokein updated this revision to Diff 240529.
hokein added a comment.
update the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73450/new/
https://reviews.llvm.org/D73450
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
hokein updated this revision to Diff 240528.
hokein marked 5 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73450/new/
https://reviews.llvm.org/D73450
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:138
IsMainFileOnly = false;
- bool IsIndexable =
- isa(RenameDecl) &&
- SymbolCollector::shouldCollectSymbol(
- cast(RenameDecl), RenameDecl.getASTContext(),
-
merge_guards_bot added a comment.
{icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed
and 815 were skipped.
{icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1
warnings
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov,
mgorny.
Herald added a project: clang.
This patch adds a simple mechanism to disallow global rename
on std symbols. We might extend it to other
18 matches
Mail list logo
