This revision was automatically updated to reflect the committed changes.
Closed by commit rG92a78750929b: [AArch64][SVE] SVE2 intrinsics for complex
integer arithmetic (authored by kmclaughlin).
Changed prior to commit:
https://reviews.llvm.org/D73636?vs=242683=243511#toc
Repository:
rG
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
Thanks @kmclaughlin , LGTM.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1115
class AdvSIMD_SVE_LOGB_Intrinsic : AdvSIMD_SVE_CNT_Intrinsic;
+ class
kmclaughlin updated this revision to Diff 242683.
kmclaughlin edited the summary of this revision.
kmclaughlin added a comment.
Changed misleading intrinsic class names used with cadd, sqcadd, cmla &
sqrdcmlah
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73636/new/
sdesmalen added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1758
+def int_aarch64_sve_sqcadd_x : AdvSIMD_2VectorArgIndexed_Intrinsic;
+def int_aarch64_sve_cmla_x : AdvSIMD_3VectorArgIndexed_Intrinsic;
+def int_aarch64_sve_cmla_lane_x
kmclaughlin marked 2 inline comments as done.
kmclaughlin added a comment.
Thanks for reviewing this @sdesmalen!
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1116
+ LLVMMatchType<0>,
+ llvm_i32_ty],
+[IntrNoMem]>;
kmclaughlin updated this revision to Diff 241675.
kmclaughlin added a comment.
- Changed complexrotateop & complexrotateopodd to use TImmLeaf
- Removed SVE2_CADD_Intrinsic & SVE2_CMLA_Intrinsic classes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73636/new/
sdesmalen added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1116
+ LLVMMatchType<0>,
+ llvm_i32_ty],
+[IntrNoMem]>;
missing ImmArg
Comment at:
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, cameron.mcinally,
c-rhodes.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
Adds the following SVE2
