[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:607 + auto D = toExprDependence(E->getType()->getDependence()); + for (auto *E : E->arguments()) +D |= E->getDependence() & ~ExprDependence::Type;

[PATCH] D73638: [AST] Move dependence computations into a separate file

dnsampaio added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:607 + auto D = toExprDependence(E->getType()->getDependence()); + for (auto *E : E->arguments()) +D |= E->getDependence() & ~ExprDependence::Type; I'm impressed this even

[PATCH] D73638: [AST] Move dependence computations into a separate file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I do think there are ways we could write the dependency computations more clearly, but don't want to diverge further from the existing code) Comment at:

[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein added inline comments. Comment at: clang/include/clang/AST/Expr.h:4081 -: Expr(ConvertVectorExprClass, DstType, VK, OK, - DstType->isDependentType(), - DstType->isDependentType() || SrcExpr->isValueDependent(), sammccall wrote: >

[PATCH] D73638: [AST] Move dependence computations into a separate file

sammccall added a comment. So this patch makes me pretty nervous - it moves a lot of logic, it necessarily changes the way it's structured, the domain is subtle. I wouldn't be terribly surprised if we were missing some tests here. So this all points to resisting the urge to improve things in

[PATCH] D73638: [AST] Move dependence computations into a separate file

hokein commandeered this revision. hokein added a reviewer: ilya-biryukov. hokein added a comment. This patch contains too many changes, most of them are just NFC, it likely takes a long time to do a full review. I actually did an review for the original patch. I have highlighted places (see

[PATCH] D73638: [AST] Move dependence computations into a separate file

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73638: [AST] Move dependence computations into a separate file

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73638: [AST] Move dependence computations into a separate file

ilya-biryukov added a comment. @rsmith this does not pass through testing, I've messed up somewhere while moving the code. I'll find what went wrong and fix it tomorrow. Please tell if the approach itself LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION