This revision was automatically updated to reflect the committed changes.
Closed by commit rGd4576080da72: [AArch64][SVE] Add remaining SVE2 intrinsics
for widening DSP operations (authored by kmclaughlin).
Changed prior to commit:
https://reviews.llvm.org/D73903?vs=244367=245114#toc
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1100
[IntrNoMem]>;
+
class SVE2_2VectorArg_Narrowing_Intrinsic
nit:
kmclaughlin updated this revision to Diff 244367.
kmclaughlin added a comment.
- Rebased & moved new intrinsics under the existing headers in
IntrinsicsAArch64.td
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73903/new/
https://reviews.llvm.org/D73903
Files:
kmclaughlin marked an inline comment as done.
kmclaughlin added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1852
-// SVE2 MLA LANE.
-def int_aarch64_sve_smlalb_lane : SVE2_3VectorArg_Indexed_Intrinsic;
sdesmalen wrote:
> nit: why
sdesmalen added inline comments.
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1852
-// SVE2 MLA LANE.
-def int_aarch64_sve_smlalb_lane : SVE2_3VectorArg_Indexed_Intrinsic;
nit: why are you moving these?
Repository:
rG LLVM Github Monorepo
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, c-rhodes.
Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: LLVM.
kmclaughlin added a parent revision: D73719:
