[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. In D73904#1874303 , @thakis wrote: > I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 > . > Please watch bots after landing patches next

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

thakis added a comment. I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 . Please watch bots after landing patches next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/8249/step_7.txt Please take a look and if it takes a while to fix, please revert while you investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

This revision was automatically updated to reflect the committed changes. Closed by commit rGc49866acceb1: [clang] stop baremetal driver to append .a to lib (authored by christof). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/

Re: [PATCH] D73904: [clang] stop baremetal driver to append .a to lib

> I'm also not sure if `-L` is a feature that is relied upon at the moment by anybody that uses the baremetal driver Unlikely, IMO. There aren’t that many users of this stuff yet, and it’s still quite rough around the edges in comparison to the GNU toolchain. Also, the compiler support libraries

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. The function @MaskRay suggested does not address the problem with `-march=` and others, but it does sound good to use that function. I'm also not sure if `-L` is a feature that is relied upon at the moment by anybody that uses the baremetal driver. For the moment I'll

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

MaskRay added a comment. A probably better approach is to use something like `TC.getCompilerRT(Args, "profile")`. The function returns a full path which can avoid `-L` problems. std::string ToolChain::getCompilerRT(const ArgList , StringRef Component,

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243896. christof added a comment. Added a test for arm-none-eabi selection Note that the selection mechanism in the Baremetal driver is rather weak. It does not seem to respond on `-mthumb`, `-march` and `-mcpu` options. The cc1 options show a normalized

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

psmith accepted this revision. psmith added a comment. This revision is now accepted and ready to land. Thanks for the update, looks good to me. The BareMetal driver tests are better than the location I suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. Just noticed the comment from Peter asking for clang/test/Driver/arm-compiler-rt.c, I'll add that in a moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof updated this revision to Diff 243868. christof added a comment. With updated tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/test/Driver/baremetal.cpp Index:

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

jroelofs added a comment. +1, looks good with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

peter.smith added a comment. I think this is the right thing to do. According to https://sourceware.org/binutils/docs/ld/Options.html#Options Add the archive or object file specified by namespec to the list of files to link. This option may be used any number of times. If namespec is of the

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof created this revision. christof added reviewers: peter.smith, jroelofs. Herald added a project: clang. Herald added a subscriber: cfe-commits. When the clang baremetal driver selects the rt.builtins static library it prefix with "-l" and appends ".a". The result is a nonsense option