[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-06 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG09a88120c926: [clang][driver][ARM] Clean up ARM target & feature checking in clang driver. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-05 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : cons

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-04 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-04 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 242516. hliao added a comment. revise formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74020/new/ https://reviews.llvm.org/D74020 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/Driver/Tool

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-04 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch <

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-04 Thread Michael Liao via Phabricator via cfe-commits
hliao updated this revision to Diff 242513. hliao added a comment. revise the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74020/new/ https://reviews.llvm.org/D74020 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/Dr

[PATCH] D74020: [ARM] Clean up ARM target & feature checking in clang driver.

2020-02-04 Thread Michael Liao via Phabricator via cfe-commits
hliao created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. - Similar to other targets, instead of passing a toolchain, a driver argument should be passed into `arm::getARMTargetFeatures` should take a driver argument. Aslo, that routine shou