[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added a comment. In D74070#1863989 , @aganea wrote: > Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 > . Pushed that to 10.x as 0e1c734fa5b88ec7efc2bcf8d45ed58f6ba48b91

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

aganea added a comment. Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74070/new/ https://reviews.llvm.org/D74070

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

rupprecht added a comment. FYI, temporarily reverted this in fafddbd956dbe439787f6d717c247e648bb07ff5 since it was causing failures in `Clang :: Driver/crash-report.c`. I didn't see the failure on all buildbots (otherwise I

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

This revision was automatically updated to reflect the committed changes. aganea marked 2 inline comments as done. Closed by commit rG5fedc2b41085: [Clang] Avoid crashing when generating crash diagnostics when #pragma clang… (authored by aganea). Changed prior to commit:

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecoveryContext::GetCurrent(); hans wrote: > Maybe also add to the

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

aganea created this revision. aganea added reviewers: hans, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `#pragma clang __debug crash` is used, currently `Driver::generateCompilationDiagnostics()` doesn't work. The `clang -E` created for diagnostics would