This revision was automatically updated to reflect the committed changes.
Closed by commit rGca9fd22adb5a: [clangd] Set "spelled" flag for
constructor references. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D74125?vs=242890&id=242911#toc
Repository:
rG LLVM Github
hokein marked 3 inline comments as done.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597
+bool IsTargetKind = NameKind == DeclarationName::Identifier ||
+ NameKind == DeclarationName::CXXConstructorName;
+b
kbobyrev accepted this revision.
kbobyrev added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:595
DeclarationName Name = DeclAndRef.first->getDeclName();
-bool Spelled = Identifier
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:597
+bool IsTargetKind = NameKind == DeclarationName::Identifier ||
+ NameKind == DeclarationName::CXXConstructorName;
+bool Spelled = IdentifierToken && IsTarg
hokein updated this revision to Diff 242890.
hokein added a comment.
update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74125/new/
https://reviews.llvm.org/D74125
Files:
clang-tools-extra/clangd/index/SymbolCollector.cpp
clang-tools-extra/c
hokein created this revision.
hokein added a reviewer: kbobyrev.
Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
DeclarationName for cxx constructor is special, it is not an identifier.
thus the "Spelled" flag are not set fo
