[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG03993f3b6f46: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb).

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. LGTM I was able to build with these changes successfully on the local builder host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249916. broadwaylamb added a comment. Use `CMAKE_CURRENT_LIST_DIR` instead of `CMAKE_SOURCE_DIR` for locating the llvm-project directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. @vvereschaka very interesting. I've downloaded CMake 3.10.2 and finally been able to reproduce the issue locally. So it //is// a CMake bug which does not appear in the latest versions. I'll update this patch to use `CMAKE_CURRENT_LIST_DIR` and add a comment.

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka added a comment. I tried to reproduce the problem on the builder in a temporary folder and I found that CMAKE_SOURCE_DIR == CMAKE_BINARY_DIR == . Here is a list of all CMAKE_ variables available on a moment of initial configuration: -- CMAKE_AR:

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb updated this revision to Diff 249779. broadwaylamb added a comment. Add one more libc++abi header search path when building libc++ @vvereschaka this is supposed to fix the buildbot failure. It's more of a sweep under the rug type of fix. The real problem is that the value of the

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb added a comment. Reverted this because it broke our buildbot: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4704/steps/build-llvm-project/logs/stdio. Going to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG801627ee490e: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake (authored by broadwaylamb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74347/new/ https://reviews.llvm.org/D74347

[PATCH] D74347: [CMake] Explicitly specify paths to libc++abi in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, aorlov, andreil99. Herald added subscribers: cfe-commits, ldionne, kristof.beyls, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. D69169 , which was necessary