This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ac0c4b46ee2: [DirectoryWatcher] Fix misuse of FSEvents API
and data race (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74371/new/
jkorous accepted this revision.
jkorous added a comment.
This revision is now accepted and ready to land.
LGTM
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74371/new/
https://reviews.llvm.org/D74371
benlangmuir created this revision.
benlangmuir added reviewers: jkorous, akyrtzi.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.
I observed two bugs in the DirectoryWatcher on macOS
1. We were calling FSEventStreamStop and FSEventStreamInvalidate before
