[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. In D74387#1895264 , @Fznamznon wrote: > @rjmccall, Thank you very much for so detailed response, It really helps. I > started working on implementation and I have a couple of questions/problems > with this particular appoach. >

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. @rjmccall, Thank you very much for so detailed response, It really helps. I started working on implementation and I have a couple of questions/problems with this particular appoach. > - If `foo` uses `__float128` (whether in its signature or internally), that > is

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. In D74387#1874612 , @Fznamznon wrote: > > In D74387#1869845 , @rjmccall > > wrote: > > > >> The right approach here is probably what we do in ObjC ARC when we see > >> types that are

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. > In D74387#1869845 , @rjmccall wrote: > >> The right approach here is probably what we do in ObjC ARC when we see types >> that are illegal in ARC: in system headers, we allow the code but add a >> special `UnavailableAttr`

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon added a comment. In D74387#1869819 , @ABataev wrote: > I would add a check for the use of unsupported types in kernels. They should > not be allowed to be used if target does not support it. Yeah, I think so. We tried to make it using

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

rjmccall added a comment. The right approach here is probably what we do in ObjC ARC when we see types that are illegal in ARC: in system headers, we allow the code but add a special `UnavailableAttr` to the declaration so that it can't be directly used. That is straightforward enough that I

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

ABataev added a comment. I would add a check for the use of unsupported types in kernels. They should not be allowed to be used if target does not support it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/

[PATCH] D74387: [SYCL] Do not diagnose use of __float128

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. While SYCL does not support __float128 for some device targets, emitting the diagnostic here prevents the compilation of host header files with __float128 type usage. For now