[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added a comment. In D74572#2042931 , @yonghong-song wrote: > @dblaikie I can revert but let me first understand the alternative way to do > the work, at least in high level. > > [ > I do believe my commit message, esp. the first couple of lines

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song added a comment. @dblaikie I can revert but let me first understand the alternative way to do the work, at least in high level. [ I do believe my commit message, esp. the first couple of lines is badly inaccurate. I suspect this is the one causing your confusion as well. speciall

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added a comment. I think it'd probably be good to revert this/other patches, and maybe have a design discussion on cfe-dev. Could you do that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572 ___

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

dblaikie added subscribers: JDevlieghere, probinson, aprantl, echristo, dblaikie. dblaikie added a comment. This seems like a fairly invasive way to preserve certain DWARF types. Are you in a position to make source changes to help here? Would it be reasonable to annotate these types with __att

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b01b465388b: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id() (authored by yonghong-song). Changed prior to commit: https://reviews.llvm.org/D74572?vs=262140&id=264256#toc Repositor

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 262140. yonghong-song edited the summary of this revision. yonghong-song added a comment. change buitin flag to the following spec: flag == 0: a local relocation against bpf_prog BTF change flag == 1: a remote relocation against kernel Repository:

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 261977. yonghong-song edited the summary of this revision. yonghong-song added a comment. add second argument to __builtin_btf_type_id(var, flag) to indicate whether a .BTF.ext relocation should be generated or not. flag == 0, no reloc, flag == 1, reloc

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 261427. yonghong-song added a comment. rebase on top of master. Fix build error due to a recent func name change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 245582. yonghong-song added a comment. fix a typo (BPFPreserveType.cpp => BPFPreserveDIType.cpp) in the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

ast accepted this revision. ast added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// ast wrote: > BPF

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 245574. yonghong-song added a comment. change llvm.bpf_pdit to llvm.btf_type_id variable name to make it easy to understand. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:95 + + std::string BaseName = "llvm.bpf_pdit."; + int Count = 0; ast wrote: > may be "llvm.btf_type_id." instead? > Oh, y

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

ast added inline comments. Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cpp:1 +//===- BPFPreserveType.cpp - Preserve DebugInfo Types -===// +// BPFPreserveDIType.cpp Comment at: llvm/lib/Target/BPF/BPFPreserveDIType.cp

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song added a comment. The corresponding clang side of change is https://reviews.llvm.org/D74668 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74572/new/ https://reviews.llvm.org/D74572 ___ cfe

[PATCH] D74572: [BPF] preserve debuginfo types for builtin __builtin__btf_type_id()

yonghong-song updated this revision to Diff 244826. yonghong-song retitled this revision from "[WIP][BPF] implement intrinsic function __builtin__btf_type_id()" to "[BPF] preserve debuginfo types for builtin __builtin__btf_type_id()". yonghong-song edited the summary of this revision. yonghong-so