michele.scandale updated this revision to Diff 246139.
michele.scandale added a comment.
Herald added a subscriber: jfb.
Tests for `__attribute__(())` syntax + attribute arguments + fix for `_Atomic`
qualifier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
aaron.ballman added inline comments.
Comment at: clang/lib/Parse/ParseTentative.cpp:773
+ while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec,
+ tok::kw_alignas)) {
+if (Tok.is(tok::l_square)) {
rsmith wrote:
> aaron
rsmith added inline comments.
Comment at: clang/lib/Parse/ParseTentative.cpp:773
+ while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec,
+ tok::kw_alignas)) {
+if (Tok.is(tok::l_square)) {
aaron.ballman wrote:
> Do we
aaron.ballman requested changes to this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: clang/lib/Parse/ParseTentative.cpp:773
+ while (Tok.isOneOf(tok::l_square, tok::kw___attribute, tok::kw___declspec,
+
michele.scandale updated this revision to Diff 246095.
michele.scandale added a comment.
Fixed comment wording + rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74643/new/
https://reviews.llvm.org/D74643
Files:
clang/include/clang/Parse/Pa
rsmith accepted this revision.
rsmith added inline comments.
Comment at: clang/include/clang/Parse/Parser.h:2444
+ /// Try to skip a possibly empty sequence of 'attribute-specifier' without of
+ /// full validation of the syntactic structure of attributes.
St
michele.scandale added a comment.
@rsmith: is this fine for you as well?
If this is ready for landing, I would appreciate if somebody can land this on
my behalf since I do not have commit rights. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
rjmccall accepted this revision.
rjmccall added a comment.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74643/new/
https://reviews.llvm.org/D74643
___
cfe-commits mailing list
cfe-commits@lists.
michele.scandale marked an inline comment as done.
michele.scandale added a comment.
Assuming this is fine, I would need someone landing this change on my behalf
since I do not have commit rights. Thanks!
Comment at: clang/lib/Parse/ParseTentative.cpp:780
+ if (!SkipUntil
michele.scandale updated this revision to Diff 245073.
michele.scandale added a comment.
Add comment about ObjC message send being rejected + rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74643/new/
https://reviews.llvm.org/D74643
Files:
rjmccall accepted this revision.
rjmccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Parse/ParseTentative.cpp:780
+ if (!SkipUntil(tok::r_square) || Tok.isNot(tok::r_square))
+return false;
+ ConsumeBracket();
-
michele.scandale marked an inline comment as done.
michele.scandale added inline comments.
Comment at: clang/lib/Parse/ParseTentative.cpp:798
+if (Tok.is(tok::l_square)) {
+ ConsumeBracket();
+ if (!SkipUntil(tok::r_square))
rjmccall wro
michele.scandale updated this revision to Diff 245068.
michele.scandale added a comment.
Check for double brackets for C++11 style attributes, and outline the loop to
skip attributes in `TrySkipAttributes` to fix also the other use in
`TryConsumeDeclarationSpecifier`
Repository:
rG LLVM Gith
rjmccall added inline comments.
Comment at: clang/lib/Parse/ParseTentative.cpp:798
+if (Tok.is(tok::l_square)) {
+ ConsumeBracket();
+ if (!SkipUntil(tok::r_square))
Do you want to check for double-brackets here?
Repository:
rG LLVM
michele.scandale created this revision.
michele.scandale added reviewers: rjmccall, rsmith.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
michele.scandale updated this revision to Diff 244756.
michele.scandale added a comment.
Missed GNU style attributes
The syntax rules
michele.scandale updated this revision to Diff 244756.
michele.scandale added a comment.
Missed GNU style attributes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74643/new/
https://reviews.llvm.org/D74643
Files:
clang/lib/Parse/ParseTentative.c
16 matches
Mail list logo