This revision was automatically updated to reflect the committed changes.
Closed by commit rGd4ad386ee195: [ARM] Fixing range checks for Neons
vqdmulhq_lane and vqrdmulhq_lane intrinsics (authored by pratlucas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
dnsampaio accepted this revision.
dnsampaio added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74766/new/
https://reviews.llvm.org/D74766
pratlucas updated this revision to Diff 249392.
pratlucas added a comment.
Clang-format.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74766/new/
https://reviews.llvm.org/D74766
Files:
clang/include/clang/Basic/arm_neon.td
pratlucas updated this revision to Diff 249346.
pratlucas added a comment.
Adding check for valid range on tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74766/new/
https://reviews.llvm.org/D74766
Files:
dnsampaio added inline comments.
Comment at: clang/test/CodeGen/arm-neon-range-checks.c:284-285
+void test_vqdmulhq_lane(int32x4_t a, int32x2_t b) {
+ vqdmulhq_lane_s32(a, b, -1); // expected-error {{argument value -1 is
outside the valid range}}
+ vqdmulhq_lane_s32(a, b, 2);
pratlucas created this revision.
Herald added subscribers: cfe-commits, kristof.beyls.
Herald added a project: clang.
The range checks performed for the vqrdmulh_lane and vqrdmulh_lane Neon
intrinsics were incorrectly using their return type as the base type for
the range check performed on their
