This revision was automatically updated to reflect the committed changes.
Closed by commit rGb17f29201089: [ASTImporter] Improved import of AlignedAttr.
(authored by balazske).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75048/new/
balazske marked an inline comment as done.
balazske added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:7944
+ if (auto ToEOrErr = Import(From->getAlignmentExpr()))
+To = AlignedAttr::Create(ToContext, true, *ToEOrErr, ToRange,
+
shafik added inline comments.
Comment at: clang/lib/AST/ASTImporter.cpp:7944
+ if (auto ToEOrErr = Import(From->getAlignmentExpr()))
+To = AlignedAttr::Create(ToContext, true, *ToEOrErr, ToRange,
+ FromAttr->getSyntax(),
balazske updated this revision to Diff 246392.
balazske added a comment.
- Do not call AlignedAttr::Create with same parameters at 2 places. I think the
code duplication was near to each other and only 2 instances that is not a big
problem, anyway now it is a bit better.
- Improved the comment
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM aside from the comments I made.
Comment at: clang/lib/AST/ASTImporter.cpp:7944
+ if (auto ToEOrErr = Import(From->getAlignmentExpr()))
+To =
balazske created this revision.
Herald added subscribers: cfe-commits, martong, teemperor, gamesh411,
Szelethus, dkrupp.
Herald added a reviewer: martong.
Herald added a reviewer: a.sidorin.
Herald added a reviewer: shafik.
Herald added a project: clang.
It is not enough to clone the attributes
