[PATCH] D75166: [clangd] Clean-up locateSymbolAt

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246690. kadircet added a comment. - Also clean usage in getSymbolInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Inde

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 246682. kadircet added a comment. Add more cleaning. getDeclAtPosition builds a SelectionTree underneath and it only operates on spelling locations inside main file. So it is invalid to pass any expansion locations to it. There is no need to call getBeginni

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

2020-02-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Get rid of calls to lexer and unnecessary source location transformations. Repository: rG LLVM Gith