[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-14 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert abandoned this revision. jdoerfert added a comment. Code is good and usable but no users anymore. If anyone wants to pick this up, feel free! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/new/ https://reviews.llvm.org/D75210

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D75210#1920206 , @jdoerfert wrote: > The reason for this patch is not there anymore. I'm fine with postponing this > patch until there is a user again, thoughts? If we don't have a use for it currently, I think we

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-12 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert planned changes to this revision. jdoerfert added a comment. The reason for this patch is not there anymore. I'm fine with postponing this patch until there is a user again, thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the issue with keeping the comment up to date from Erich (but please only land this once D75779 is approved, as that's what

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-03-06 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert updated this revision to Diff 248845. jdoerfert added a comment. Pass parsed attribute kind explicitly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75210/new/ https://reviews.llvm.org/D75210 Files:

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-28 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D75210#1898012 , @aaron.ballman wrote: > I think this direction is reasonable to go with, but would prefer to land > this with the code actually using this functionality (as there's not really a > good way to test it,

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I think this direction is reasonable to go with, but would prefer to land this with the code actually using this functionality (as there's not really a good way to test it, otherwise). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked an inline comment as done. jdoerfert added a comment. In D75210#1894370 , @erichkeane wrote: > I don't see anything glaring here, but I would love some better explanation > as to the goal here. I don't see this used anywhere, the commit

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I don't see anything glaring here, but I would love some better explanation as to the goal here. I don't see this used anywhere, the commit message is a bit underwhelming in its reasoning, and there is no test/etc showing why I would want this.

[PATCH] D75210: [Attr] Allow ParsedAttr to be constructor for any Attribute

2020-02-26 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert created this revision. jdoerfert added reviewers: erichkeane, aaron.ballman, rjmccall, john.brawn. Herald added a subscriber: bollu. Herald added a project: clang. ParsedAttr is used for `clang attribute push/pop` a utility that is reusable in other contexts as well. This allows us to