This revision was automatically updated to reflect the committed changes.
Closed by commit rGad497658d25a: [OpenMP] Allow const parameters in declare
simd linear clause (authored by huntergr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75350/new/
fpetrogalli accepted this revision.
fpetrogalli added a comment.
LGTM, thank you @huntergr !
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75350/new/
https://reviews.llvm.org/D75350
___
cfe-commits
huntergr updated this revision to Diff 247614.
huntergr added a comment.
- Removed the ) my editor helpfully added to the CHECK line
- Added a test to declare_simd_aarch64.c
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75350/new/
fpetrogalli added inline comments.
Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:327
+// CHECK-DAG: "_ZGVbN2l__Z11constlineari"
+// CHECK-DAG: "_ZGVcN4l__Z11constlineari"
I think we should add the same checks in the AArch64 test:
huntergr updated this revision to Diff 247294.
huntergr added a comment.
- Added a function body to the test so that it would generate symbols
- Added check lines to ensure the mangled name is present
- Reformatted the params of Sema::CheckOpenMPLinearDecl to comply with coding
style.
huntergr added inline comments.
Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118
+#pragma omp declare simd notinbranch linear(i)
+double constlinear(const int i);
+
fpetrogalli wrote:
> Shouldn't you check that the `_ZGV *` name is generated?
Ok, and I
fpetrogalli added inline comments.
Comment at: clang/test/OpenMP/declare_simd_codegen.cpp:118
+#pragma omp declare simd notinbranch linear(i)
+double constlinear(const int i);
+
Shouldn't you check that the `_ZGV *` name is generated?
Repository:
rG LLVM
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75350/new/
https://reviews.llvm.org/D75350
huntergr created this revision.
huntergr added reviewers: ABataev, kkwli0.
Herald added a subscriber: guansong.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
Section 2.19.3 (List Item Privatization) of the OpenMP 5.0 standard does not
apply to declarative directives, only to
