[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

2020-03-02 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe planned changes to this revision. jbcoe added a comment. Handle ??, ?. and ?[ in lib/Format/FormatTokenLexer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75368/new/ https://reviews.llvm.org/D75368 ___ cfe-commits mailing list

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

2020-03-02 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:237 +// C# support +PUNCTUATOR(questionquestion, "??") +PUNCTUATOR(questionlsquare, "?[") I think this is not a good place to add these. I think these

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

2020-02-28 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 247399. jbcoe added a comment. Fix failing test by parsing tokens after '?[' in the same way as tokens after '['. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75368/new/ https://reviews.llvm.org/D75368 Files:

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

2020-02-28 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of the tests with real source code where public static void Main(string[] args) { string dirPath = args?[0]; } is (mis)-formatted as public static void

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

2020-02-28 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe planned changes to this revision. jbcoe added a comment. There's a weird test failure I'm unable to reproduce outside of