danielkiss added a comment.
Please update the title and the summary because those will be the commit
message.
IMHO the test a case would be extended with a test where the body of the
modified if condition is tested.
Otherwise LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75453/ne
j0le added a comment.
I would like to ask, whether I could "Accept the Revision" myself, or is this
only allowed to be done by code owners or other reviewers?
And when the revision is accepted, do I have to commit this, or can this only
be done by people who have commit access or is this done au
j0le updated this revision to Diff 255354.
j0le added a comment.
I added a test case.
I hope the folder "clang/tests/Driver" is the right one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75453/new/
https://reviews.llvm.org/D75453
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
Herald added a subscriber: danielkiss.
Seems reasonable, though this isn't UB, its just use of an uninitialized
variable.
Please add a test case.
Repository:
rG LLVM Github M
j0le created this revision.
j0le added a reviewer: compnerd.
j0le added a project: clang.
Herald added a subscriber: kristof.beyls.
Hello everyone,
this is my first patch to/for clang. I hope, I did everything right. If not,
please tell me.
I found this bug:
If you execute the following command
