[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG070acb1d1e51: [Driver][ARM] parse version of arm/thumb architecture correctly (authored by danielkiss). Repository: rG

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss added a comment. @j0le patch is landed but I just realised the review is still blocked by @compnerd. So it won't be closed I think, that is my bad. https://github.com/llvm/llvm-project/commit/070acb1d1e51ffd289a46b8f93e993635d0053b7 CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. In D75453#2094938 , @danielkiss wrote: > Sorry for the delay, it is okay to say "ping" after a while :) > LGTM Hi Daniel, no problem, thanks for comming back to this review after that long time. I will say "ping" next time :) Can

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss added a comment. j0le, I will commit later this week for you. compnerd do you have any comment for this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing lis

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss accepted this revision. danielkiss added a comment. Sorry for the delay, it is okay to say "ping" after a while :) LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mai

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le updated this revision to Diff 260912. j0le retitled this revision from "[Driver][ARM] fix undefined behaviour when checking architecture version" to "[Driver][ARM] parse version of arm/thumb architecture correctly". j0le edited the summary of this revision. j0le added a comment. Changed tit