This revision was automatically updated to reflect the committed changes.
Closed by commit rG314b9278f097: Revert [CGBlocks] Improve line info in
backtraces containing *_helper_block (authored by aprantl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Nice! Lgtm, thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75615/new/
https://reviews.llvm.org/D75615
___
cfe-commits mailing list
aprantl updated this revision to Diff 248285.
aprantl added a comment.
Good catch, and non-obvious resolution.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75615/new/
https://reviews.llvm.org/D75615
Files:
clang/lib/CodeGen/CGBlocks.cpp
clang/test/CodeGenObjC/debug-info-blocks.m
vsk added inline comments.
Comment at: clang/test/CodeGenObjC/debug-info-blocks.m:24
// CHECK: load {{.*}}, !dbg ![[DESTROY_LINE:[0-9]+]]
-// CHECK: ret void, !dbg ![[DESTROY_LINE]]
+// CHECK-DAG: [[DBG_LINE]] = !DILocation(line: 0, scope: ![[COPY_SP:[0-9]+]])
aprantl updated this revision to Diff 248190.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75615/new/
https://reviews.llvm.org/D75615
Files:
clang/lib/CodeGen/CGBlocks.cpp
clang/test/CodeGenObjC/debug-info-blocks.m
Index: clang/test/CodeGenObjC/debug-info-blocks.m
aprantl updated this revision to Diff 248192.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75615/new/
https://reviews.llvm.org/D75615
Files:
clang/lib/CodeGen/CGBlocks.cpp
clang/test/CodeGenObjC/debug-info-blocks.m
Index: clang/test/CodeGenObjC/debug-info-blocks.m
aprantl created this revision.
aprantl added reviewers: vsk, shafik.
aprantl added a project: debug-info.
aprantl updated this revision to Diff 248190.
aprantl updated this revision to Diff 248192.
Block copy/destroy helpers are now `linkonce_odr` functions, meant to be
uniqued, and thus
