[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-11 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D75665#2084889 , @thakis wrote: > This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for reporting this, i think the output

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. This breaks check-clang on mac: http://45.33.8.238/mac/15258/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-10 Thread Endre Fülöp via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG020815fafd15: [analyzer] On-demand parsing capability for CTU (authored by gamesh411). Changed prior to commit: https://reviews.llvm.org/D75665?vs=269677=269749#toc Repository: rG LLVM Github

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269677. gamesh411 added a comment. add ambiguity checking during invocation list parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269644. gamesh411 added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269639. gamesh411 added a comment. add ambiguous invocation list test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269615. gamesh411 added a comment. use consumeError in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:119-120 + return "Invocation list file contains multiple references to the same " + "source" + " file."; +case

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269527. gamesh411 added a comment. Fix test case, and reorder warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-06-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 269439. gamesh411 added a comment. Extend index file format Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-29 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 ___ cfe-commits mailing list

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-29 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 267143. gamesh411 marked 6 inline comments as done. gamesh411 added a comment. Fix documentation and commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-28 Thread Whisperity via Phabricator via cfe-commits
whisperity resigned from this revision. whisperity added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:26 +#include "llvm/ADT/Triple.h" +#include "llvm/Option/ArgList.h" #include

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 2 inline comments as done. gamesh411 added a comment. The remaining documentation and test changes are also underway. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:227 +/// Identifier. +virtual LoadResultTy load(StringRef Identifier) =

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 266473. gamesh411 marked 29 inline comments as done. gamesh411 added a comment. Update functional changes, documentation update incoming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-20 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. Hi Endre, just checked the latest update. Overall looks good to me, but found some nits. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:260 +/// that produce the AST used for analysis. +StringRef OnDemandParsingDatabase; +

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-12 Thread Whisperity via Phabricator via cfe-commits
whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. (Maybe this will make Phab not show "✅ Accepted"...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-12 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. Please check the summary of the patch, it seems to contain old information as well. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:210-212 +Preferably the same compilation database should be used when generating the external

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-12 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:362 - return ASTUnit::LoadFromASTFile( - std::string(ASTFilePath), CI.getPCHContainerOperations()->getRawReader(), - ASTUnit::LoadEverything, Diags, CI.getFileSystemOpts()); +

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-05-11 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 263294. gamesh411 added a comment. Implement a solution without a dependency on clangTooling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-28 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260554. gamesh411 added a comment. Remove arch target from another invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked an inline comment as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CMakeLists.txt:13 clangIndex + clangTooling + clangSerialization thakis wrote: > We've been very careful to make clang (the compiler binary) only

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260310. gamesh411 added a comment. [NFC] Fix arcanist double commit revisioning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260308. gamesh411 added a comment. Remove platform constraint from test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 reopened this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Non-linux buildbots were utterly broken :( . Trying to fix them... Thanks for reverting this for me :) Also I will investigate the possibility to not depend on Tooling. Repository:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. Reverted in https://github.com/llvm/llvm-project/commit/96717125e852d1c6ddf41c22dd2d556f4f5aa34d. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. Sorry, this change broke a couple bots that are in the official CI, at least http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/7566 and http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/66618. I'm reverting this

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this also breaks tests on Windows and Mac, eg http://45.33.8.238/win/13902/step_7.txt It probably makes sense to revert while you investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/lib/CrossTU/CMakeLists.txt:13 clangIndex + clangTooling + clangSerialization We've been very careful to make clang (the compiler binary) only depend on clangToolingCore and not on the much bigger clangTooling

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 closed this revision. gamesh411 added a comment. I am landing this. Thanks for the reviews @martong @balazske @xazax.hun @whisperity ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260238. gamesh411 added a comment. Fix index error enum declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-27 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260229. gamesh411 added a comment. Reword enum value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-25 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. @whisperity Thanks for the review :3 Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:111-114 + -Xclang -analyzer-config -Xclang experimental-enable-naive-ctu-analysis=true \ + -Xclang -analyzer-config -Xclang ctu-dir=. \

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-25 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 260078. gamesh411 marked 15 inline comments as done. gamesh411 added a comment. Fix issues in documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-23 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:391 +Currently On-demand analysis is not supported with `scan-build-py`. \ No newline at end of file What's this line? Is this added by Phab, or is this a weird

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-22 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:227 +/// Identifier. +virtual LoadResultTy load(StringRef Identifier) = 0; +virtual ~ASTLoader() = default; xazax.hun wrote: > martong wrote: > > xazax.hun

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-21 Thread Whisperity via Phabricator via cfe-commits
whisperity added inline comments. Comment at: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst:21 + +PCH based analysis +__ I think it's PCH-based with a -. Comment at:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. Ok, looks good to me. The minor nit regarding the naming is easy to fix before commit. The design question I had is not a blocker, my suggested alternative can be implemented later (if desired) in a backward-compatible way from the

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-21 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:56 + load_threshold_reached, + ambiguous_compile_commands_database }; xazax.hun wrote: > The two enum values refer to compilation database and compile command >

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-20 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:56 + load_threshold_reached, + ambiguous_compile_commands_database }; The two enum values refer to compilation database and compile command database. I'd prefer

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-20 Thread Gabor Marton via Phabricator via cfe-commits
martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Thanks Endre for the docs! I checked the CI job also, seemed okay, so, I think we are ready! Nice work! Let's do the commit! Comment at:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-20 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 258674. gamesh411 added a comment. Update user documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-16 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 258092. gamesh411 added a comment. Add ambiguous compilation database test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-16 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 257985. gamesh411 marked an inline comment as done. gamesh411 added a comment. Rebase and update the number of analyzer options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 5 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:457 +return llvm::make_error( +index_error_code::ambiguous_compile_commands_database); + martong wrote: > Could we

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 257896. gamesh411 marked an inline comment as done. gamesh411 added a comment. Implement review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 marked 23 inline comments as done. gamesh411 added a comment. Answered most review comments. Thanks for the reviewers @balazske, @martong so far. The question of absolute path policy is still up for debate. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. The tests are getting better, thanks Endre! Comment at: clang/test/Analysis/ctu-on-demand-parsing.c:5 +// RUN: cp "%S/Inputs/ctu-other.c" "%t/ctu-other.c" +// RUN: echo '[{"directory":"%t","command":"gcc -c -std=c89 -Wno-visibility

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-15 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 257622. gamesh411 added a comment. Reorganize test code to overcome testing infrastructure limitations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-09 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D75665#1971440 , @gamesh411 wrote: > In D75665#1907914 , @martong wrote: > > > The warning below suggests that we parse the ctu-other.c file (and > > presumably every file) as a C++

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D75665#1907914 , @martong wrote: > The warning below suggests that we parse the ctu-other.c file (and presumably > every file) as a C++ file, even if it should be parsed as a C file. Perhaps > the invocation of the parser

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D75665#1907938 , @martong wrote: > > As the CTUDir string prefix is only needed in case of the old approach, I > > have refactored the external definition mapping storage to NOT include that. > > Both `ctu-main.c` and

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-04-09 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 256212. gamesh411 added a comment. Herald added a subscriber: ASDenysPetrov. Refactored the test Copying the compile_commands.json in case of test for C files results in the extdef mapping tool finding the correct compiler flags for the C to be imported.

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-06 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365 + llvm::SmallString<256> AbsPath = CTUDir; + llvm::sys::path::append(AbsPath, Identifier); Could we check somehow if `CTUDir` is indeed an absolute path? If not then

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-06 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:222 + + struct ASTLoader { +/// Load the ASTUnit by an identifier. Subclasses should determine what this `class` would look better here? (The descendants are

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:578 + + // Optional OnDemandParsingDatabase; + // if (Opts.CTUOnDemandParsing) left here some debugging Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:23 #include "llvm/ADT/StringMap.h" +#include "llvm/IR/DiagnosticInfo.h" +#include "llvm/IR/OperandTraits.h" Perhaps this include is needed only in the .cpp file?

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. > As the CTUDir string prefix is only needed in case of the old approach, I > have refactored the external definition mapping storage to NOT include that. Both `ctu-main.c` and `ctu-on-demand-parsing.c` use the `-analyzer-config ctu-dir=%t/ctudir2` setting. So it is

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. The warning below suggests that we parse the ctu-other.c file (and presumably every file) as a C++ file, even if it should be parsed as a C file. Perhaps the invocation of the parser is missing some setting? Also, could this be the reason why on-the-fly and pch driven

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. This patch adds an alternative way of loading ASTs to provide the CTU definitions needed during analysis. The additional approach is to use Tooling with a user-provided compile_commands.json, and look up the needed file from the output of the ext-def-mapping tool

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

2020-03-05 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 created this revision. gamesh411 added reviewers: martong, balazske. Herald added subscribers: cfe-commits, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity, mgorny. Herald added a reviewer: