[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

sammccall added a comment. In D75739#1912051 , @hokein wrote: > In D75739#1909637 , @sammccall wrote: > > > So the core of this is a better version of my patch, thanks! > > It does work around the problem with

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ba0a4ec3bbf: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein marked 2 inline comments as done. hokein added a comment. In D75739#1909637 , @sammccall wrote: > So the core of this is a better version of my patch, thanks! > It does work around the problem with dot-to-arrow, which is useful and we > should

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein updated this revision to Diff 249046. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75739/new/ https://reviews.llvm.org/D75739 Files:

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

njames93 added a comment. How does this handle cases where an object overloads the `->` operator or worse still overloads the operator and has conflicting names when accessed with `. ` or `->`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. So the core of this is a better version of my patch, thanks! It does work around the problem with dot-to-arrow, which is useful and we should definitely enable that. However I actually

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The previous issue is that the item was filtered out by vscode, because the prefix (which contains ".") are