[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f5d1261c9a: [ASTImporter] Corrected import of repeated friend declarations. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f5d1261c9a: [ASTImporter] Corrected import of repeated friend declarations. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske updated this revision to Diff 275343. balazske added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

martong added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3638 + /// Number of similar looking friends. + unsigned int TotalCount; + /// Index of the specific FriendDecl. shafik wrote: > `uint32_t` >

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske updated this revision to Diff 249317. balazske marked an inline comment as done. balazske added a comment. Removed code repetition. Using `const char *` instead of `auto`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

shafik added a comment. LGTM WDYT @teemperor Comment at: clang/lib/AST/ASTImporter.cpp:3638 + /// Number of similar looking friends. + unsigned int TotalCount; + /// Index of the specific FriendDecl. `uint32_t` Is there a reason to not prefer fixed width

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske marked 9 inline comments as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3640 + auto *RD = cast(FD->getLexicalDeclContext()); + if (FD->getFriendType()) { +QualType TypeOfFriend =

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske updated this revision to Diff 249100. balazske marked 2 inline comments as done. balazske added a comment. Fixes according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75740/new/ https://reviews.llvm.org/D75740 Files:

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

a_sidorin added a comment. Hello Balazs, This look almost good to me except some comments inline. Comment at: clang/lib/AST/ASTImporter.cpp:3635 +static std::tuple +getFriendCountAndPosition(FriendDecl *FD) { It's better to turn the tuple into a named struct

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske created this revision. Herald added subscribers: cfe-commits, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Import declarations in correct order if a class contains multiple redundant