[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-23 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. That's right David, this typo was fixed in a reverted and re-applied commit: https://reviews.llvm.org/D75856, https://reviews.llvm.org/D75747 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-21 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. The mention of "C++ object initializers" in the commit message is a typo, yes? (it should be "C# object initializers" I assume?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3f20d27c9e: [clang-format] Correct indentation for `[key] = value,` entries in C++ object… (authored by Jonathan Coe jb...@google.com). Changed prior to commit:

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-09 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 ___ cfe-commits mailing list

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-09 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe updated this revision to Diff 249155. jbcoe added a comment. Format code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 Files: clang/lib/Format/ContinuationIndenter.cpp clang/unittests/Format/FormatTestCSharp.cpp Index:

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-09 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. Looks good! I'll stamp this after https://reviews.llvm.org/D75731 gets merged and this rebased on top of it. Comment at:

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-06 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe added a comment. Requires https://reviews.llvm.org/D75731 to be merged first. Do not use continuation indent for '['

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

2020-03-06 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. Requires https://reviews.llvm.org/D75731 to be merged first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 ___ cfe-commits mailing