[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

This revision was automatically updated to reflect the committed changes. Closed by commit rG843a9778fcd5: Add a warning for builtin_return_address/frame_address with 0 argument (authored by jstenglein, committed by erichkeane). Changed prior to commit:

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1912519 , @erichkeane wrote: > I did a bit of research and I don't think i know of anything better than > 'most' here, and noone else had an opinion at the end of last week so I'll > take that silence as consent.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I did a bit of research and I don't think i know of anything better than 'most' here, and noone else had an opinion at the end of last week so I'll take that silence as consent.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

lebedev.ri resigned from this revision. lebedev.ri added a reviewer: aaron.ballman. lebedev.ri added a comment. This seems reasonable to me but i'll defer to other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75768/new/

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1910339 , @erichkeane wrote: > In D75768#1910324 , @jstenglein > wrote: > > > In D75768#1910303 , @erichkeane > > wrote: > > > > >

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane added a comment. In D75768#1910324 , @jstenglein wrote: > In D75768#1910303 , @erichkeane > wrote: > > > Any reason to not put this in -Wall like GCC? I'm not terribly > > knowledgeable about the

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1910303 , @erichkeane wrote: > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable > about the intended guidance for adding to Wmost, so if you can clarify this > decision I'd be grateful.

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane added a comment. Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine. Repository: rG LLVM Github Monorepo

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein created this revision. jstenglein added reviewers: efriedma, lebedev.ri, rsmith, erichkeane. jstenglein added a project: clang. Herald added a subscriber: cfe-commits. Clang is missing a warning for __builtin_return_address/__builtin_frame_address called with > 0 argument. Gcc