[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast added a comment. In D75786#1916714 , @aaron.ballman wrote: > In D75786#1916637 , @RKSimon wrote: > > > @PaulkaToast This patch appears to have caused a buildbot issue, please can > > you investigate/re

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

aaron.ballman added a comment. In D75786#1916637 , @RKSimon wrote: > @PaulkaToast This patch appears to have caused a buildbot issue, please can > you investigate/revert: > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/buil

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

RKSimon added a comment. @PaulkaToast This patch appears to have caused a buildbot issue, please can you investigate/revert: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/63869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

This revision was automatically updated to reflect the committed changes. PaulkaToast marked an inline comment as done. Closed by commit rGebdb98f254f6: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for… (authored by PaulkaToast). Changed prior to commit: https://rev

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast marked 2 inline comments as done. PaulkaToast added a comment. Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-restrict-system-includes.rst:48 + + A string containing a comma separated glob list of allowed include + filenames. Similar to the -c

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248900. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75786/new/ https://reviews.llvm.org/D75786 Files: clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt clang-tools-extra/clang-tidy/fuchsia/FuchsiaTid

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:130 ^^ +- The 'fuchsia-restrict-system-headers' check was renamed to :doc:`portability-restrict-system-includes + Please insert empty line above. Repositor

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast updated this revision to Diff 248882. PaulkaToast marked 5 inline comments as done. PaulkaToast added a comment. Thanks for the heads up phosek, I removed the check from fuchsia's directory. Also addressed Eurgene.Zelenko's comments. (: Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:107 + + Moved fuchsia's restrict-system-includes check to portability to allow for + general use. I don't think that this statement is necessary. Commen

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

MaskRay added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:123 +- New alias :doc:`fuchsia-restrict-system-includes + ` to Delete `fuchsia-restrict-system-includes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. We're not using this module in Fuchsia at the moment, so I'd be fine not having an alias at all, if we start using it again in the future we'll use the new name. Repository: rG LLVM Github

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

PaulkaToast created this revision. PaulkaToast added a reviewer: aaron.ballman. PaulkaToast added a project: clang-tools-extra. Herald added subscribers: cfe-commits, phosek, xazax.hun, mgorny. Herald added a project: clang. Created a general check for restrict-system-includes under portability as