[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping. Do you have an estimate when you update this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing lis

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Are you still working on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Some comments but I haven't gone through all of it. The tests are still missing. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6334 + + for (auto i = Clauses.rbegin(); i < Clauses.rend(); i++) { +OMPWhenClause *WhenClause = dyn_cast(*i);

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 291449. alokmishra.besu added a comment. Updated patch to make it extendable to more selectors Implemented device_arch and implementation_vendor selectors as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. reverse ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added a comment. In D76211#2212203 , @jdoerfert wrote: > Are you planning to add support for the actual OpenMP selectors as well? > All the other traits, scoring, etc. I left a comment below that points you to > the right place as we ha

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert updated this revision to Diff 284961. jdoerfert added a comment. Update for @alokmishra.besu via arcanist as the webinterface doesn't allow patches over 2MB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.or

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Are you planning to add support for the actual OpenMP selectors as well? All the other traits, scoring, etc. I left a comment below that points you to the right place as we have almost all

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 255575. alokmishra.besu added a comment. Updated the test cases. Fixed an issue where correct code was not generated if directive variant was not provided in when/default clause Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D76211: OpenMP Metadirective with user defined condition

tomdeakin added a comment. Herald added a subscriber: yaxunl. Is there an update on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailin

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5801 +Expr *expr = whenClause->getExpr(); +Stmt *stmt = NULL; + Style: start names with upper case letter. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5817 +

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. Apologies for my delay. In D76211#1940445 , @alokmishra.besu wrote: > Updated the test files It seems there is only an AST dump test case. Where is the codegen tests (and others)? Repository: rG LLVM Github Monorepo CHA

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 252472. alokmishra.besu marked an inline comment as not done. alokmishra.besu added a comment. Updated the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D7

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250966. alokmishra.besu marked 6 inline comments as done. alokmishra.besu added a comment. Fixed formatting issues and replaced SmallVector with ArrayRef . Working on the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:350 + friend class ASTStmtReader; + Stmt* IfStmt; + ABataev wrote: > This must be a part of the tail-allocated data members, otherwise you won't > be able to correctly hand

[PATCH] D76211: OpenMP Metadirective with user defined condition

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:863 +/// clause with user defined condition. +class OMPWhenClause : public OMPClause { + friend class OMPClauseReader; `final` Comment at: clang/include/clang/AS

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250830. alokmishra.besu added a comment. Fixed build error and test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 Files: clang/include/clang-c/Index.h

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu updated this revision to Diff 250684. alokmishra.besu added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Adding test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://revi

[PATCH] D76211: OpenMP Metadirective with user defined condition

alokmishra.besu created this revision. alokmishra.besu added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, martong, jfb, arphaman, guansong, jholewinski. Herald added a project: clang. jdoerfert added a comment. I think you forgot to add the tests to the commit :) This is a patc

[PATCH] D76211: OpenMP Metadirective with user defined condition

jdoerfert added a comment. I think you forgot to add the tests to the commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76211/new/ https://reviews.llvm.org/D76211 ___ cfe-commits mailing list cfe