[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24bb2d1e7768: [clangd] Add a tweak for adding using statement. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added a comment. In D76432#1952798 , @sammccall wrote: > Still LG, should I land this? Yes please :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall added a comment. Still LG, should I land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 ___ cfe-commits mailing list

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:89 + + // If we're looking at a type or NestedNameSpecifier, walk up the tree until + // we find the "main" node we care about, which would be ElaboratedTypeLoc or

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253583. adamcz marked 10 inline comments as done. adamcz added a comment. review round 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files:

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:206 + tooling::Replacements R; + if (auto Err = R.add(tooling::Replacement( + SM, CharSourceRange::getTokenRange(NNSL.getSourceRange()), "", sammccall

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:245 + auto = Inputs.AST->getSourceManager(); + auto TB = Inputs.AST->getTokens(); + // Determine the length of the qualifier under the cursor, then remove it.

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, thanks! Let me know if/when I should land this for you. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:105 +// argument. +bool

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253165. adamcz added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz updated this revision to Diff 253164. adamcz marked 22 inline comments as done. adamcz added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 Files:

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:34 +// True iff "using" already exists and we should not add it. +bool IdenticalUsingFound = false; +// Location to insert the "using" statement.

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall added a comment. This seems really well-thought-out. I'm being (even) more verbose than usual about the interesting AST details. Please do push back/defer fixing anything that adds a lot of complexity and doesn't seem important. Comment at:

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

adamcz created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This triggers on types and function calls with namespace qualifiers. The action is to remove the qualifier and