[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. Yes, looks fixed by 6d7637d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. In D76451#2004069 , @thakis wrote: > This breaks tests on Windows: http://45.33.8.238/win/13855/step_9.txt > > Please take a look and revert while you do if it takes a while to investigate. @nridge hold off on the revert, I

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/13855/step_9.txt Please take a look and revert while you do if it takes a while to investigate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

This revision was automatically updated to reflect the committed changes. Closed by commit rG230cae89db3f: [clangd] Enable textual fallback for go-to-definition on dependent names (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:569 ASTResults = locateASTReferent(NearbyIdent->location(), NearbyIdent, AST, - *MainFilePath, Index); + *MainFilePath,

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259483. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files:

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. Thanks for your patience! Comment at: clang-tools-extra/clangd/XRefs.cpp:154 +getDeclAtPosition(ParsedAST , SourceLocation Pos, DeclRelationSet Relations, + bool *IsDependentName = nullptr) { unsigned Offset =

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge updated this revision to Diff 259160. nridge added a comment. Rebase on top of D75479 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 Files:

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76451/new/ https://reviews.llvm.org/D76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:234 ParsedAST , llvm::StringRef MainFilePath, - const SymbolIndex *Index) { + const SymbolIndex *Index, bool

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. nridge marked an inline comment as done. nridge added inline comments. Comment