[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

thakis added a comment. For CDE and MVE, the sema inc file is called arm_foo_builtin_sema. Does it make sense to call the sve one arm_sve_builtin_sema instead of arm_sve_sema_rangechecks too, for consistency? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8a5b30bac69: [SveEmitter] Add range checks for immediates and predicate patterns. (authored by sdesmalen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76678/new/ https://reviews.llvm.org/D76678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen added a comment. In D76678#1963576 , @SjoerdMeijer wrote: > LGTM, please wait a day in case Eli has more comments. Will do, thanks Sjoerd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76678/new/ https://reviews.llvm.org/D76678

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. LGTM, please wait a day in case Eli has more comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76678/new/ https://reviews.llvm.org/D76678

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen updated this revision to Diff 255278. sdesmalen marked 3 inline comments as done. sdesmalen added a comment. - Renamed `ImmCheckPredicatePattern` -> `ImmCheck0_31` - Updated tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76678/new/ https://reviews.llvm.org/D76678

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:153 +} +def ImmCheckPredicatePattern: ImmCheckType<0>; // 0..31 +def ImmCheck1_16: ImmCheckType<1>; // 1..16

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7571 + else if (Builtin->LLVMIntrinsic != 0) { +llvm::Type* OverloadedTy = getSVEType(TypeFlags); + I'm not sure why you need a second way to convert SVE types separate from

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

SjoerdMeijer added a comment. Did a first scan, looks very reasonable, just some first nits/questions inlined. Comment at: clang/include/clang/Basic/arm_sve.td:153 +} +def ImmCheckPredicatePattern: ImmCheckType<0>; // 0..31 +def ImmCheck1_16:

[PATCH] D76678: [SveEmitter] Add range checks for immediates and predicate patterns.

sdesmalen created this revision. sdesmalen added reviewers: efriedma, SjoerdMeijer, rovka. Herald added subscribers: mgrang, tschuett, mgorny. Herald added a project: clang. sdesmalen added a child revision: D76679: [SveEmitter] Add more immediate operand checks.. This patch adds a mechanism to